-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Optimize number js #39132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.4-develop
Are you sure you want to change the base?
Optimize number js #39132
Conversation
Hi @rogerdz. Thank you for your contribution! Add the comment under your pull request to deploy test or vanilla Magento instance:
❗ Automated tests can be triggered manually with an appropriate comment:
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
@magento run all tests |
app/code/Magento/Checkout/view/frontend/web/js/view/minicart.js
Outdated
Show resolved
Hide resolved
@magento run all tests |
app/code/Magento/Checkout/view/frontend/web/template/minicart/content.html
Show resolved
Hide resolved
app/code/Magento/Checkout/view/frontend/web/template/minicart/content.html
Outdated
Show resolved
Hide resolved
app/code/Magento/Ui/view/base/web/js/lib/knockout/bindings/scope.js
Outdated
Show resolved
Hide resolved
app/code/Magento/Ui/view/base/web/js/lib/knockout/bindings/scope.js
Outdated
Show resolved
Hide resolved
@magento run all tests |
@magento run Unit Tests, Static Tests, Functional Tests EE, Functional Tests CE, Functional Tests B2B |
1 similar comment
@magento run Unit Tests, Static Tests, Functional Tests EE, Functional Tests CE, Functional Tests B2B |
@engcom-Hotel seem it still optimize. |
Hello @rogerdz, We have checked the Total Blocking Time for both the 2.4-develop branch and this branch, but it is showing Please let us know to get the total JavaScript execution time have you used any extensions? Thanks |
Hello @rogerdz, Have you had a chance to look into this #39132 (comment)? Thanks |
Hi @engcom-Hotel, |
@magento run all tests |
Hello @rogerdz, We have rechecked this PR on https://pagespeed.web.dev/ and we are still getting similar results: Without PR Changes: On Mobile Device Without PR Changes: On Computer With PR Changes: On Mobile Device We have followed the same steps as mentioned here #39132 (comment). Please let us know if we missed anything. Thanks |
Hello @rogerdz, Have you got a chance to look into this #39132 (comment)? Thanks |
Hello @rogerdz, We have noticed that this PR has not been updated for a while. Therefore, we are closing it for now. Please let us know when you are ready to work on it again, and we will be happy to reopen the PR. Thank you for your valuable contribution! |
Hello @rogerdz, As we can see you have reopened this PR and started working on it, hence we are moving this PR Please let us know, by when we can pick it for further processing. Thanks |
Description (*)
Self test in default magento:
For more complex sites, more optimization may be possible.
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)
Resolved issues: