Skip to content

Optimize number js #39132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 21 commits into
base: 2.4-develop
Choose a base branch
from
Draft

Optimize number js #39132

wants to merge 21 commits into from
+210 −35

Conversation

rogerdz
Copy link
Contributor

@rogerdz rogerdz commented Sep 1, 2024 •
edited by m2-assistant bot
Loading

Description (*)

  • only execute js with element display in viewport
  • only trigger binding with element display in viewport
  • add event mousemove for execute for another js

Self test in default magento:

  • number of requests reduced 20-30rq when loading page
  • Total Blocking Time reduced 20-30ms on Lighthouse
  • JavaScript execution time reduced 1s on Lighthouse

For more complex sites, more optimization may be possible.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Optimize number js #39200: Optimize number js

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Sep 1, 2024

Hi @rogerdz. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@rogerdz
Copy link
Contributor Author

rogerdz commented Sep 1, 2024

@magento run all tests

ihor-sviziev
ihor-sviziev reviewed Sep 2, 2024
View reviewed changes
@ihor-sviziev ihor-sviziev added Area: Performance Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels Sep 2, 2024
@rogerdz
Copy link
Contributor Author

rogerdz commented Sep 5, 2024

@magento run all tests

jemoon
jemoon reviewed Sep 7, 2024
View reviewed changes
jemoon
jemoon reviewed Sep 7, 2024
View reviewed changes
@Priyakshic Priyakshic added the Project: Community Picked PRs upvoted by the community label Sep 12, 2024
@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Bravo engcom-Bravo added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Sep 17, 2024
@engcom-Hotel engcom-Hotel self-requested a review September 17, 2024 10:12
@engcom-Hotel
Copy link
Contributor

@magento run Unit Tests, Static Tests, Functional Tests EE, Functional Tests CE, Functional Tests B2B

1 similar comment
@engcom-Hotel
Copy link
Contributor

@magento run Unit Tests, Static Tests, Functional Tests EE, Functional Tests CE, Functional Tests B2B

@rogerdz
Copy link
Contributor Author

rogerdz commented Jan 8, 2025

@engcom-Hotel seem it still optimize.
Can you compare Total Blocking Time and JavaScript execution time ?

@engcom-Hotel
Copy link
Contributor

Hello @rogerdz,

We have checked the Total Blocking Time for both the 2.4-develop branch and this branch, but it is showing 0 MS for both. Please refer to the below screenshots:

Branch 2.4-develop
image

Branch requirejs-optimize
image

Please let us know to get the total JavaScript execution time have you used any extensions?

Thanks

@engcom-Hotel
Copy link
Contributor

Hello @rogerdz,

Have you had a chance to look into this #39132 (comment)?

Thanks

@rogerdz
Copy link
Contributor Author

rogerdz commented Feb 3, 2025

Hi @engcom-Hotel,
I checked again and result still same as #39132 (comment).
Can we test on https://pagespeed.web.dev ?

@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Hotel
Copy link
Contributor

Hello @rogerdz,

We have rechecked this PR on https://pagespeed.web.dev/ and we are still getting similar results:

Without PR Changes: On Mobile Device
image

Without PR Changes: On Computer
image

With PR Changes: On Mobile Device
image

With PR Changes: On Computer
image

We have followed the same steps as mentioned here #39132 (comment).

Please let us know if we missed anything.

Thanks

@engcom-Hotel
Copy link
Contributor

Hello @rogerdz,

Have you got a chance to look into this #39132 (comment)?

Thanks

@engcom-Hotel
Copy link
Contributor

Hello @rogerdz,

We have noticed that this PR has not been updated for a while. Therefore, we are closing it for now.

Please let us know when you are ready to work on it again, and we will be happy to reopen the PR.

Thank you for your valuable contribution!

@rogerdz rogerdz reopened this May 15, 2025
@engcom-Charlie engcom-Charlie moved this to Changes Requested in Community Dashboard Jun 19, 2025
@engcom-Hotel
Copy link
Contributor

Hello @rogerdz,

As we can see you have reopened this PR and started working on it, hence we are moving this PR On Hold and mark it as draft.

Please let us know, by when we can pick it for further processing.

Thanks

@engcom-Hotel engcom-Hotel moved this from Changes Requested to On Hold in Community Dashboard Jul 9, 2025
@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this from On Hold to Review in Progress in Community Dashboard Jul 9, 2025
@engcom-Hotel engcom-Hotel marked this pull request as draft July 9, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev left review comments

@jemoon jemoon jemoon left review comments

@engcom-Hotel engcom-Hotel Awaiting requested review from engcom-Hotel

Assignees

@ihor-sviziev ihor-sviziev

@jemoon jemoon

@engcom-Hotel engcom-Hotel

Labels
Area: Performance Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: on hold Project: Community Picked PRs upvoted by the community Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Community Dashboard
Status: Review in Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Optimize number js
8 participants
@rogerdz @engcom-Hotel @fabiopelloso @iparmentier @ihor-sviziev @jemoon @engcom-Bravo @Priyakshic